Do checks inside the job and compute the classpath entries#1897
Merged
laeubi merged 1 commit intoeclipse-pde:masterfrom Jul 25, 2025
Merged
Do checks inside the job and compute the classpath entries#1897laeubi merged 1 commit intoeclipse-pde:masterfrom
laeubi merged 1 commit intoeclipse-pde:masterfrom
Conversation
Currently some checks are performed outside the update job, for example the model is fetched and the javanature. These values can change between submit the data to the job and it actually pick it up. This now moves these check into the job itself and uses a concurrent queue to prevent the need for synchronized. Also results are collected inside a Map so if new update request are received in the meanwhile we discard the previous computed values. Beside that, entries are now eagerly computed as they are required anyways when we set the classpath and we can catch problems that occur here instead of just swallow them. Also the job now react to cancel request much better than before.
laeubi
force-pushed
the
do_more_in_the_job
branch
from
686e11f to
b6976f9
Compare
Test Results 765 files 765 suites 48m 41s ⏱️ Results for commit b6976f9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently some checks are performed outside the update job, for example the model is fetched and the javanature. These values can change between submit the data to the job and it actually pick it up.
This now moves these check into the job itself and uses a concurrent queue to prevent the need for synchronized. Also results are collected inside a Map so if new update request are received in the meanwhile we discard the previous computed values.
Beside that, entries are now eagerly computed as they are required anyways when we set the classpath and we can catch problems that occur here instead of just swallow them.
Also the job now react to cancel request much better than before.